razzor/torrent-stats
1
0
Fork 0
Code Issues Pull Requests Releases Activity

fix logging

Browse Source
This commit is contained in:
Olaf Rempel 2009-10-21 14:46:11 +02:00
parent e164b672f7
commit be762c9abd
2 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
process.c
View File

@ -58,8 +58,10 @@ struct child_process * childproc_alloc(char *const argv[], const char *pwd)
int childproc_free(struct child_process *child) int childproc_free(struct child_process *child)
{ {
/* child already running, return error */ /* child already running, return error */
if (child->pid != 0) if (child->pid != 0) {
log_print(LOG_ERROR, "childproc_free(): process [pid:%d] already running", child->pid);
return -1; return -1;
}
int i; int i;
for (i = 0; child->argv[i] != NULL; i++) for (i = 0; child->argv[i] != NULL; i++)
@ -76,12 +78,12 @@ pid_t childproc_fork(struct child_process *child, void (*exit_cb)(struct child_p
{ {
struct stat stat_buf; struct stat stat_buf;
if (stat(child->argv[0], &stat_buf) != 0) { if (stat(child->argv[0], &stat_buf) != 0) {
log_print(LOG_ERROR, "spawn_child(): stat()"); log_print(LOG_ERROR, "childproc_fork(): stat()");
return -1; return -1;
/* not a regular file, or not executable */ /* not a regular file, or not executable */
} else if (!S_ISREG(stat_buf.st_mode) || !(stat_buf.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH))) { } else if (!S_ISREG(stat_buf.st_mode) || !(stat_buf.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH))) {
log_print(LOG_ERROR, "spawn_child(): stat()"); log_print(LOG_ERROR, "childproc_fork(): stat()");
return -1; return -1;
} }
@ -100,7 +102,7 @@ pid_t childproc_fork(struct child_process *child, void (*exit_cb)(struct child_p
int child_pipes[3][2]; int child_pipes[3][2];
if (child->fd[STDIN_FILENO] == -1) { if (child->fd[STDIN_FILENO] == -1) {
if (pipe(child_pipes[STDIN_FILENO]) < 0) { if (pipe(child_pipes[STDIN_FILENO]) < 0) {
log_print(LOG_ERROR, "spawn_child(): pipe(STDIN_FILENO)"); log_print(LOG_ERROR, "childproc_fork(): pipe(STDIN_FILENO)");
return -1; return -1;
} }
@ -111,7 +113,7 @@ pid_t childproc_fork(struct child_process *child, void (*exit_cb)(struct child_p
if (child->fd[STDOUT_FILENO] == -1) { if (child->fd[STDOUT_FILENO] == -1) {
if (pipe(child_pipes[STDOUT_FILENO]) < 0) { if (pipe(child_pipes[STDOUT_FILENO]) < 0) {
log_print(LOG_ERROR, "spawn_child(): pipe(STDOUT_FILENO)"); log_print(LOG_ERROR, "childproc_fork(): pipe(STDOUT_FILENO)");
return -1; return -1;
} }
@ -122,7 +124,7 @@ pid_t childproc_fork(struct child_process *child, void (*exit_cb)(struct child_p
if (child->fd[STDERR_FILENO] == -1) { if (child->fd[STDERR_FILENO] == -1) {
if (pipe(child_pipes[STDERR_FILENO]) < 0) { if (pipe(child_pipes[STDERR_FILENO]) < 0) {
log_print(LOG_ERROR, "spawn_child(): pipe(STDERR_FILENO)"); log_print(LOG_ERROR, "childproc_fork(): pipe(STDERR_FILENO)");
return -1; return -1;
} }
@ -169,7 +171,7 @@ pid_t childproc_fork(struct child_process *child, void (*exit_cb)(struct child_p
exit(1); exit(1);
} else if (child->pid < 0) { /* fork error */ } else if (child->pid < 0) { /* fork error */
log_print(LOG_ERROR, "spawn_child(): fork()"); log_print(LOG_ERROR, "childproc_fork(): fork()");
return -1; return -1;
} else { /* parent */ } else { /* parent */
@ -199,7 +201,7 @@ void childproc_cleanup(void)
int status = 0; int status = 0;
int ret = waitpid(child->pid, &status, WNOHANG); int ret = waitpid(child->pid, &status, WNOHANG);
if (ret == -1) { if (ret == -1) {
log_print(LOG_WARN, "sigchld_handler(): waitpid(%d)", child->pid); log_print(LOG_WARN, "childproc_cleanup(): waitpid(%d)", child->pid);
continue; continue;
} else if (ret != 0 && WIFEXITED(status)) { } else if (ret != 0 && WIFEXITED(status)) {

10
torrentfile.c
View File

@ -80,10 +80,12 @@ int destroy_torrent(struct torrent_file *torrent)
/* remove us from list */ /* remove us from list */
list_del(&torrent->list); list_del(&torrent->list);
/* check if we're seeding, destroy after sigchld */ /* check if we're still seeding, and deferr the destroy after sigchld */
if (torrent->child != NULL) { if (torrent->child != NULL) {
torrent->destroy = 1; torrent->destroy = 1;
kill(SIGTERM, torrent->child->pid); if (kill(SIGTERM, torrent->child->pid) < 0)
log_print(LOG_WARN, "failed to kill ctorrent [pid:%d]", torrent->child->pid);
return 0; return 0;
} }
@ -102,6 +104,7 @@ static void child_exit(struct child_process *child, int exit_code, void *privdat
close(child->fd[STDOUT_FILENO]); close(child->fd[STDOUT_FILENO]);
close(child->fd[STDERR_FILENO]); close(child->fd[STDERR_FILENO]);
/* destroy was deferred until our child died, so do it now */
if (torrent->destroy) if (torrent->destroy)
destroy_torrent(torrent); destroy_torrent(torrent);
} }
@ -132,6 +135,9 @@ int seed_torrent(struct torrent_file *torrent)
char *const args[] = { (char *)ctorrent_bin, "-S", (char *)statserv, "-f", buf, NULL }; char *const args[] = { (char *)ctorrent_bin, "-S", (char *)statserv, "-f", buf, NULL };
torrent->child = childproc_alloc(args, searchpath); torrent->child = childproc_alloc(args, searchpath);
if (torrent->child == NULL)
return -1;
if (childproc_fork(torrent->child, child_exit, torrent) < 0) { if (childproc_fork(torrent->child, child_exit, torrent) < 0) {
log_print(LOG_ERROR, "spawn_child(%s)", args[0]); log_print(LOG_ERROR, "spawn_child(%s)", args[0]);
childproc_free(torrent->child); childproc_free(torrent->child);